Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 generating timeout_in_minutes silently fails unless ALL steps provide a non-zero value #90

Open
reececomo opened this issue Jul 19, 2022 · 0 comments

Comments

@reececomo
Copy link

Expected output

- label: ":bash: My pipeline"
  commands:
    - script_a.sh
    - script_b.sh
  timeout_in_minutes: 20

Failure cases

new CommandStep(['script_a.sh', new Command('script_b.sh', 20)], ':bash: My pipeline');
// expected: timeout_in_minutes: 20
// received: timeout_in_minutes: 0 ❌

new CommandStep([new Command('script_a.sh'), new Command('script_b.sh', 20)], ':bash: My pipeline');
// expected: timeout_in_minutes: 20
// received: timeout_in_minutes: 0 ❌

new CommandStep([new Command('script_a.sh', 0), new Command('script_b.sh', 20)], ':bash: My pipeline');
// expected: timeout_in_minutes: 20
// received: 💥 ArgumentError: Expected number `timeout` to be positive, got 0

Workaround

new CommandStep([new Command('script_a.sh', 1), new Command('script_b.sh', 19)], ':bash: My pipeline');
// expected: timeout_in_minutes: 20
// received: timeout_in_minutes: 20 ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant