New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'createSubscribeQuery' only works when share is connected under WebSockets #391

Open

matthewbauer opened this issue Sep 8, 2015 · 0 comments

matthewbauer commented Sep 8, 2015

I'm pretty sure this is because "socket.canSendWhileConnecting" is not set- but _createQuery will silently fail in WebSockets like this:

var proto = 'ws'
var collection = 'files'
var socket = new WebSocket(proto + '://' + location.hostname + ':' + location.port)
var sharejs = require('share/lib/client/index')
var share = new sharejs.Connection(socket)

var query = share.createSubscribeQuery(collection, {}, {docMode:'sub'}, function(err, documents) {
  console.log('not called')
})

while this will work as expected:

var proto = 'ws'
var collection = 'files'
var socket = new WebSocket(proto + '://' + location.hostname + ':' + location.port)
var sharejs = require('share/lib/client/index')
var share = new sharejs.Connection(socket)

share.on('connected', function() {
  var query = share.createSubscribeQuery(collection, {}, {docMode:'sub'}, function(err, documents) {
    console.log('called')
  })
})

So, for WebSockets/BCSockets consistency the above should probably throw an error when canSendWhileConnecting is false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment