You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So the current implementation gives the client an etag which is already nice but the browser will still send out a request. Using the connect.static maxAge parameter sets the caching headers so the browser will not even send a request for the code, speeding up the connection.
It is desirable to turn off this header while developing the client code, so some sort of option would have to be settable, but I think setting the default to at least a day is probably a good idea.
The text was updated successfully, but these errors were encountered:
I think so - but I'm not sure what the maxAge parameter should be set to. I guess it could be configurable. I won't get to this myself - its too low on my priority list.
So the current implementation gives the client an etag which is already nice but the browser will still send out a request. Using the connect.static maxAge parameter sets the caching headers so the browser will not even send a request for the code, speeding up the connection.
https://github.com/senchalabs/connect/blob/a9f20e450b8c197e22da41d3d1d610685878489d/lib/middleware/static.js#L168
Since you're not using connect.static I think it may be enough to just add the header at
node-browserchannel/lib/server.coffee
Line 840 in bfc517f
but there may be some subtlety involved.
It is desirable to turn off this header while developing the client code, so some sort of option would have to be settable, but I think setting the default to at least a day is probably a good idea.
The text was updated successfully, but these errors were encountered: