-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move package to pure js #44
Comments
... I'm currently working through a couple of changes in the 2.0 branch to make browserchannel use node streams & closer fit the websocket API. Hold off on porting it to JS for a week or two. |
Figured this would stay in the backlog for a bit. Marked #23 as ready. |
I ported the client to closurey javascript in a branch. It has a couple of bugs - and generally I'm not super happy with the result. It looks a lot harder to maintain... |
What about porting to babel? https://github.com/babel/babel |
Thanks @dashed I've been meaning to check out babel for some time. This might be a good excuse to try out some es6 |
Better than coffeescript ;) |
lol @3rd-Eden assuming the expectation is that es6 eventually won't require compilation, but that is a ways off |
can I require the client in a babel-compiled front-end application currently? |
Should do. |
As discussed, node-browserchannel may eventually be ported from coffeescript to javascript. If this happens, coffeescript would continue to be used for the test suite.
The coffeescript should be compiled to javascript, and the javascript should be cleaned up manually in small commits. At no point should the test suite be broken.
The text was updated successfully, but these errors were encountered: