Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move package to pure js #44

Open
wenzowski opened this issue Feb 23, 2014 · 10 comments
Open

move package to pure js #44

wenzowski opened this issue Feb 23, 2014 · 10 comments

Comments

@wenzowski
Copy link
Collaborator

As discussed, node-browserchannel may eventually be ported from coffeescript to javascript. If this happens, coffeescript would continue to be used for the test suite.

The coffeescript should be compiled to javascript, and the javascript should be cleaned up manually in small commits. At no point should the test suite be broken.

@josephg
Copy link
Owner

josephg commented Feb 23, 2014

... I'm currently working through a couple of changes in the 2.0 branch to make browserchannel use node streams & closer fit the websocket API. Hold off on porting it to JS for a week or two.

@wenzowski wenzowski added this to the 2.0 milestone Feb 23, 2014
@wenzowski
Copy link
Collaborator Author

Figured this would stay in the backlog for a bit. Marked #23 as ready.
If you add the other features as issues as well, I'll keep an eye on the waffle.

@josephg
Copy link
Owner

josephg commented Jul 8, 2014

I ported the client to closurey javascript in a branch. It has a couple of bugs - and generally I'm not super happy with the result. It looks a lot harder to maintain...

@dashed
Copy link

dashed commented Mar 5, 2015

What about porting to babel? https://github.com/babel/babel

@wenzowski
Copy link
Collaborator Author

Thanks @dashed I've been meaning to check out babel for some time. This might be a good excuse to try out some es6

@3rd-Eden
Copy link
Contributor

3rd-Eden commented Mar 5, 2015

wat

So you want to move from one compile language straight into something else that requires compilation?

@dashed
Copy link

dashed commented Mar 5, 2015

Better than coffeescript ;)

@wenzowski
Copy link
Collaborator Author

lol @3rd-Eden assuming the expectation is that es6 eventually won't require compilation, but that is a ways off

@TomKaltz
Copy link

can I require the client in a babel-compiled front-end application currently?

@josephg
Copy link
Owner

josephg commented Nov 10, 2016

Should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants