Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with duckplyr #7

Closed
krlmlr opened this issue Apr 27, 2024 · 3 comments
Closed

Errors with duckplyr #7

krlmlr opened this issue Apr 27, 2024 · 3 comments

Comments

@krlmlr
Copy link

krlmlr commented Apr 27, 2024

When checking starschemar with a version of dplyr that uses duckdb under the hood, I'm seeing errors that I'm having a hard time understanding.

The error message is:

! `x` must be a vector, not a <tbl_df/tbl/data.frame/dimension_table> object.

It seems odd that "dimension_table" comes last in the list of classes, even after "data.frame" . Is this intended? The typical way would be to put it first, as in class = c("dimension_table", "tbl_df", "tbl", "data.frame") .

Thank you for your support.

I also wonder if and how your package could interoperate with dm: cynkra/dm#2212.

@josesamos
Copy link
Owner

The order of the classes had been corrected in the code but remained in the data included in the package. I have modified all the datasets according to the current code so that the dimension_table or fact_table classes are now the first in the list.

I think that would be corrected with that and can it could interoperate with dm. It's already updated on GitHub, I'm going to send it to CRAN.

I'm sorry for any possible inconvenience.

@krlmlr
Copy link
Author

krlmlr commented May 1, 2024

Thank you, José. Should we discuss the potential for interop with dm in cynkra/dm#2212?

My motivation for this issue are my attempts to check starschemar with duckplyr.

@josesamos
Copy link
Owner

You are welcome. Yes, without problem. Now I have availability for whatever needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants