Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only half of syntax highlight #30

Closed
atsju opened this issue Jan 3, 2023 · 21 comments
Closed

only half of syntax highlight #30

atsju opened this issue Jan 3, 2023 · 21 comments

Comments

@atsju
Copy link

atsju commented Jan 3, 2023

The syntax highlight is absolutely not like in your preview.
See an example of my files:
image
Can you help fix that ?

I note 15 uncaught errors under runtime status if it can help : Cannot read properties of undefined (reading 'document')

Please come back to me if you need more information.

@josetr
Copy link
Owner

josetr commented Jan 3, 2023

Is it happening in all files or only in this one?

Ideally, I would need the source code that reproduces the issue.

@atsju
Copy link
Author

atsju commented Jan 3, 2023

All files.
I can not provide the source code of professional code. You can understand that as your sources are closed.
Anyway, same is reproduced with any code, as for example with folder https://github.com/ObKo/stm32-cmake/tree/master/examples/blinky
Is there debug information I can share ?

@josetr
Copy link
Owner

josetr commented Jan 3, 2023

I completely understand, that's why I was only talking about the necessary source code that reproduces the issue (which is usually a few lines long and can be filled with random data)

Can you try disabling all the vscode plugins that you have to make sure one of them is not conflicting with this one?

Mind sharing your operating system?

I've cloned the repo that you have provided and it works perfectly well for me:

image

@atsju
Copy link
Author

atsju commented Jan 3, 2023

I run windows 10
I disabled absolutely ALL extensions except yours:
image

@josetr
Copy link
Owner

josetr commented Jan 3, 2023

I just noticed that I'm seeing the same error as you, but in my case, the extension still continues to work.

Do you see any errors here:

image

@atsju
Copy link
Author

atsju commented Jan 3, 2023

everything fine here
image
image

@josetr
Copy link
Owner

josetr commented Jan 3, 2023

I've released a new version 0.0.8 which should fix the issue that you've mentioned. Please let me know if that is enough to get the whole extension to start working.

@atsju
Copy link
Author

atsju commented Jan 4, 2023

No better in 0.8.0. No color, still runtime status errors, no error in console.
image

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

0.0.9 available now, please try it out 👍

@atsju
Copy link
Author

atsju commented Jan 4, 2023

not OK (but no more uncaught error ?)
image

Also let me remind you of this issue: #26

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

I forgot to ask, is syntax highlighting the only thing that isn't fully working?

Does auto-completion / signature help / rename work?

@atsju
Copy link
Author

atsju commented Jan 4, 2023

autocompletion OK
signature help OK
help OK
rename OK

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

Open Command Palette => Developer: Inspect editor Tokes and Scopes

Then click over the "set" function

image

@atsju
Copy link
Author

atsju commented Jan 4, 2023

image
image

I add one that is working for information
image

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

Are you using a different vscode theme? If so, that may be the problem.

@atsju
Copy link
Author

atsju commented Jan 4, 2023

I use "Dark (visual studio)" which I believe is default one

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

I don't think it's the default one - try Dark+ (default dark)

@atsju
Copy link
Author

atsju commented Jan 4, 2023

OK this was it. Can you please fix this ?
I would rather have a coloration that doesn't fit with my theme choice than no coloration at all.
Especially when half of coloration is working.

@josetr
Copy link
Owner

josetr commented Jan 4, 2023

But I think this is how it's supposed to look like. If you don't like it, that's why they provide Dark+.

If you open a TypeScript / C# file, using the Dark (Visual Studio) theme, the functions won't have any colorization either.

@atsju
Copy link
Author

atsju commented Jan 4, 2023

Correct, other themes work with their own colors.

I don't remember having change the theme. Thanks for support.

@atsju atsju closed this as completed Jan 4, 2023
@USTHzhanglu
Copy link

But I think this is how it's supposed to look like. If you don't like it, that's why they provide Dark+.

If you open a TypeScript / C# file, using the Dark (Visual Studio) theme, the functions won't have any colorization either.

I'm also having this issue and trying to find/fix it took me a lot of time, maybe we can give a hint in the introduction to help more people who are having the same issue (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants