Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partialVisibility bottom remains visible when the viewport is below the component #158

Open
wescorwin opened this issue May 8, 2019 · 0 comments

Comments

@wescorwin
Copy link

Hello!

This library has been very useful but there's a small functionality issue with partialVisibility that I'm not sure works as intended.

When partialVisibility is set to 'bottom', the sensor triggers when the bottom of the element is visible (as desired). But then, when the user scrolls away from the element, to the point that the card is out of the viewport, the sensor still claims the element is visible.

In the below demo, try changing partialVisibility to 'bottom' then scroll below the red bar. You'll observe that the output claims "Contained Element is now visible"

https://codepen.io/joshwnj/pen/PjwVym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant