Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadable support broken between 0.5.0 and 0.4.1 on StrictMode #17

Open
robertmusil opened this issue Aug 14, 2023 · 1 comment
Open

loadable support broken between 0.5.0 and 0.4.1 on StrictMode #17

robertmusil opened this issue Aug 14, 2023 · 1 comment

Comments

@robertmusil
Copy link

Minimal reproduction demo (based on Pokemon example): https://codesandbox.io/s/hardcore-feather-lljsfl?file=/src/App.tsx

  • Upon hard refresh, the loadable state quickly changes from loading to hasError
  • Any subsequent hmr refreshes actually resolve to hasData
  • Removing React.StrictMode resolves the problem (hides it?)
  • This behavior is not observed in 0.4.1
@dai-shi
Copy link
Member

dai-shi commented Aug 16, 2023

Thanks for reporting.

Removing React.StrictMode resolves the problem (hides it?)

pmndrs/jotai#2076 might or might not be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dai-shi @robertmusil