Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing LV2 in Carla doesn't change the canvas size #11

Open
unfa opened this issue May 4, 2021 · 8 comments
Open

Resizing LV2 in Carla doesn't change the canvas size #11

unfa opened this issue May 4, 2021 · 8 comments

Comments

@unfa
Copy link

unfa commented May 4, 2021

I've tested the plug-in in Carla today and resizing does't seem to work.

I can resize the window, but the plug-in still redraws only the same area of it, leaving the rest with garbage.

@jpcima
Copy link
Owner

jpcima commented May 4, 2021

Carla is not letting the plugin know about the resize.
puglReshape not called, but working in Jalv
@falkTX, perhaps you have an idea of why that is?

@unfa
Copy link
Author

unfa commented May 4, 2021

Interestingly Wolf Spectrum does resize correctly in Carla (it does not in Ardour though).

@jpcima
Copy link
Owner

jpcima commented May 4, 2021

Right thats' because Patrick cheated it, he implements his custom resize handle.
This issue is with WM-managed resizing.

@unfa
Copy link
Author

unfa commented May 4, 2021

I think this is an issue with LV2 in general. I don't know about VST3, but LV2 plug-ins have issues with resizing all the time.
Maybe we're lacking some standardized way of communicating this?

@jpcima
Copy link
Owner

jpcima commented May 4, 2021

Highly doubtful, I'll dig in Carla later to check what really happens

@jpcima
Copy link
Owner

jpcima commented May 4, 2021

Ok it comes down to this, an unimplemented in DPF
return 1; // This needs more testing

For reference https://github.com/DISTRHO/DPF/blob/89cbdbba5320c8f8822885b510307bef0c7a428f/distrho/src/DistrhoUILV2.cpp#L509-L510

@falkTX
Copy link

falkTX commented May 4, 2021

resizing has been a problematic thing in dpf (partially because of pugl)
I am reworking the dgl/graphics stuff in dpf right now, which should fix this situation but will take some time until it is complete.
You can follow the (re)work at https://github.com/DISTRHO/DPF/commits/pugl-upstream-v2
But not much to see at this point.

@luzpaz
Copy link

luzpaz commented Dec 5, 2023

Is this still an issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants