You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thing though - in the readme you are mentioning that it is possible to forbid some words from being generate as a unique key. Yet the code does not use this array. Or am I missing something?
I've found commit that does add the feature c788542
But I cannot find a commit that removes the usage of forbidden_keys in the code that generates the unique key.
The text was updated successfully, but these errors were encountered:
You're right, it seems along the way we dropped this feature. AFAIK this was not a conscious decision to remove this, and I suspect it was an unintended side effect of some refactoring. I am guessing that we didn't have a spec exercising this behaviour and someone neatened up the code without realizing the impact (similarly it slipped past reveiw). I will look at adding it back in, or alternatively if you would like this feature in a rush a PR would be most welcome.
Hi,
thanks for this gem, it made our work easier.
One thing though - in the readme you are mentioning that it is possible to forbid some words from being generate as a unique key. Yet the code does not use this array. Or am I missing something?
I've found commit that does add the feature c788542
But I cannot find a commit that removes the usage of
forbidden_keys
in the code that generates the unique key.The text was updated successfully, but these errors were encountered: