Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbidden_keys feature #104

Open
asok opened this issue Aug 31, 2018 · 1 comment
Open

forbidden_keys feature #104

asok opened this issue Aug 31, 2018 · 1 comment

Comments

@asok
Copy link
Contributor

asok commented Aug 31, 2018

Hi,
thanks for this gem, it made our work easier.

One thing though - in the readme you are mentioning that it is possible to forbid some words from being generate as a unique key. Yet the code does not use this array. Or am I missing something?

I've found commit that does add the feature c788542
But I cannot find a commit that removes the usage of forbidden_keys in the code that generates the unique key.

@jpmcgrath
Copy link
Owner

You're right, it seems along the way we dropped this feature. AFAIK this was not a conscious decision to remove this, and I suspect it was an unintended side effect of some refactoring. I am guessing that we didn't have a spec exercising this behaviour and someone neatened up the code without realizing the impact (similarly it slipped past reveiw). I will look at adding it back in, or alternatively if you would like this feature in a rush a PR would be most welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants