Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning; !default should only be written once for each variable. #1155

Open
EKoetsjarjan opened this issue Apr 25, 2024 · 1 comment

Comments

@EKoetsjarjan
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

I have got a deprecation warning

!default should only be written once for each variable.
This will be an error in Dart Sass 2.0.0.
   ╷
10 │ $box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default !default;
   │                                                        ^^^^^^^^
   ╵

Here is the diff that solved the warning:

diff --git a/node_modules/react-widgets/scss/popup.scss b/node_modules/react-widgets/scss/popup.scss
index 3ddc5c5..9c812a7 100644
--- a/node_modules/react-widgets/scss/popup.scss
+++ b/node_modules/react-widgets/scss/popup.scss
@@ -7,7 +7,7 @@ $border: $widget-border-color !default;
 $border-radius: $widget-border-radius !default;
 $box-shadow-offset: 1em !default;
 $box-shadow: 0 0.5em 1em rgba(#000, 0.175) !default;
-$box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default !default;
+$box-shadow-up: 0 0.5em 1em rgba(#000, 0.175) !default;
 
 $zindex: 1005 !default;
 $zindex-focused: $zindex + 1 !default;

This issue body was partially generated by patch-package.

@olmobrutall
Copy link
Contributor

I also get this issue, and updating to latest sass also warnings related to global built-in functions

Deprecation Warning on line 70, column 42 of file:///C:/code/x/node_modules/react-widgets/scss/components.scss:70:42:
Global built-in functions are More info and automated migrator: https://sass-lang.com/d/import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants