Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for related model collections #145

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

SamuelJennings
Copy link
Contributor

Improved documentation regarding FormCollections with many-to-one relationships as per #110.

Please let me know if it is clear enough or if you want me to change anything.

@jrief
Copy link
Owner

jrief commented Jun 27, 2024

Thanks. I will merge this in 1.5.1. When redefining the models, I first have to migrate the models on the documentation site.

@jrief jrief added the documentation Improvements or additions to documentation label Jun 27, 2024
@tuky
Copy link

tuky commented Jul 1, 2024

Great findings and thx for the documentation. Maybe you could add a code comment to lines 226 and 245 a la # attribute name has to match the related_name (see note below)? that would make the reference even more clear.

@SamuelJennings
Copy link
Contributor Author

Updated with additional code comments.

@tolland
Copy link

tolland commented Sep 9, 2024

yes. Hit same problem

@jrief jrief merged commit 2b6d080 into jrief:releases/1.5 Jan 17, 2025
@jrief
Copy link
Owner

jrief commented Jan 17, 2025

Thanks for this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants