pyinstrument 4.1.1 / python 3.11 & 3.12 compatibility

[BastienGauthier]

Hello,

I am aware of the pyarrow blocker for streamlit full compatibility with python 3.12. I would like to mention another issue linked to pyinstrument here. The 4.1.1 version seems to be not compatible with python 3.12. Starting from 4.2 it works like a charm.

Would it be possible to bump the pyinstrument poetry version, as python 3.12 is now released ?

Cheers,
Bastien

[BastienGauthier]

@jrieke, would it work for you to drop the now obsolete python 3.7 support and updating the poetry requirement to something like :

[tool.poetry.dependencies]
python = "^3.8"
streamlit = "^1.0.0"
pyinstrument = "^4.2"

?

[jrieke]

In principle yes but I assume it would break some of the styling stuff. I'm not entirely sure anymore but I think that was the reason I pinned the version to 4.1.1 here. Unfortunately, I don't have time to look into this right now. If you want to, feel free to try out how it would look like with pyinstrument pinned to a more recent version (we should probably still stick to one pinned version so it doesn't break anything in the future). If there are no styling issues or if you can easily resolve them, I'm happy to review a PR.

(Note that if it requires major changes, I may not have the time to review the PR right now. You're still welcome to open it but no guarantees on when I'll get to it.)