Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForceVec interface consistency #35

Open
vsamy opened this issue Jun 8, 2020 · 0 comments
Open

ForceVec interface consistency #35

vsamy opened this issue Jun 8, 2020 · 0 comments

Comments

@vsamy
Copy link

vsamy commented Jun 8, 2020

Hi,

so I have been thinking or ForceVec and MotionVec interface and I think there is an inconsistency between the two when it comes to their subvalues.
To get the subvalues a MotionVec, one use .angular() or .linear() while for ForceVec it is .torque(), .couple() and .force().

I think the ForceVec should only have a .angular() and .linear(). For MotionVector, we use .angular() because it can have an angular velocity or acceleration or jerk or ... It should be the same for ForceVec since it can represent others variables than torque and force (like angular/linear momentum and force derivatives).
Another reason for this, is that it makes both interface the same which is less confusing.

What do you think?

Best,

Vinccent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant