Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some println! to be more CLI / TUI friendly #52

Open
qkzk opened this issue Feb 21, 2023 · 2 comments · May be fixed by #48
Open

remove some println! to be more CLI / TUI friendly #52

qkzk opened this issue Feb 21, 2023 · 2 comments · May be fixed by #48

Comments

@qkzk
Copy link

qkzk commented Feb 21, 2023

I'm using pdf-extract in a tui file manager, where I preview the files on demand.

Sometimes, when the pdf is corrupted, there's some println!("Unicode mismatch"); on the screen which I can't prevent.

Could those prints be replaced with logs instead like it's proposed here

I can count 5 other prints in lib.rs.

joepio added a commit to joepio/pdf-extract that referenced this issue Feb 25, 2023
joepio added a commit to joepio/pdf-extract that referenced this issue Feb 25, 2023
@jrmuizel
Copy link
Owner

jrmuizel commented Mar 4, 2023

Do you have an example PDF that shows this?

@mihaimaganu17
Copy link

Hello, I get the same output printed. My case is Intel's SDM manual, volume 2
https://www.intel.com/content/www/us/en/developer/articles/technical/intel-sdm.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants