You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use two different libraries for formatting jrnl's output: colorama and rich. Over the past few years, we've been replacing other display dependencies (such as ansiwrap #1191) with rich's functionality, in part because rich was better-maintained than the alternatives, but also because it's just simpler to have less dependencies.
rich already supports all the colors we list in the config reference along with a lot more, so this shouldn't be a breaking change. Also, it won't completely remove colorama in all cases as it is a sub-dependency of some dev dependencies, but at least we won't be managing a direct dependency to it.
Example Usage
n/a - jrnl calls will be the same, except the color config keys should support rich's list of colors
Other Information
A resolution to this issue should include:
removal of colorama dependency
a change to the coloring code (currently in Entry.py, though someday I hope to find it a new home) to use rich instead of colorama
Use Case/Motivation
We use two different libraries for formatting jrnl's output:
colorama
andrich
. Over the past few years, we've been replacing other display dependencies (such as ansiwrap #1191) with rich's functionality, in part because rich was better-maintained than the alternatives, but also because it's just simpler to have less dependencies.rich
already supports all the colors we list in the config reference along with a lot more, so this shouldn't be a breaking change. Also, it won't completely removecolorama
in all cases as it is a sub-dependency of some dev dependencies, but at least we won't be managing a direct dependency to it.Example Usage
n/a - jrnl calls will be the same, except the
color
config keys should support rich's list of colorsOther Information
A resolution to this issue should include:
The text was updated successfully, but these errors were encountered: