diff --git a/src/main/java/org/jruby/ext/openssl/X509Extension.java b/src/main/java/org/jruby/ext/openssl/X509Extension.java index 3c9c3fa2..5f8bf8c8 100644 --- a/src/main/java/org/jruby/ext/openssl/X509Extension.java +++ b/src/main/java/org/jruby/ext/openssl/X509Extension.java @@ -661,11 +661,16 @@ private static boolean formatGeneralName(final GeneralName name, final ByteList append(':'); final byte[] ip = ((ASN1OctetString) name.getName()).getOctets(); int len = ip.length; boolean ip4 = len == 4; - for ( int i = 0; i < ip.length; i++ ) { - out.append( ConvertBytes.intToCharBytes( ((int) ip[i]) & 0xff ) ); - if ( i != len - 1 ) { - if ( ip4 ) out.append('.'); - else out.append(':').append(':'); + if ( ip4 ) { + for ( int i = 0; i < ip.length; i++ ) { + out.append( ConvertBytes.intToCharBytes( ((int) ip[i]) & 0xff ) ); + if ( i != len - 1 ) out.append('.'); + } + } + else { + for ( int i = 0; i < ip.length; i += 2 ) { + out.append( ConvertBytes.intToHexBytes( ((ip[i] & 0xff) << 8 | (ip[i+1] & 0xff)) ) ); + if ( i != len - 2 ) out.append(':'); } } break; diff --git a/src/main/java/org/jruby/ext/openssl/X509ExtensionFactory.java b/src/main/java/org/jruby/ext/openssl/X509ExtensionFactory.java index cf691704..52459cd8 100644 --- a/src/main/java/org/jruby/ext/openssl/X509ExtensionFactory.java +++ b/src/main/java/org/jruby/ext/openssl/X509ExtensionFactory.java @@ -490,69 +490,62 @@ private ASN1Encodable parseIssuerAltName(final ThreadContext context, final Stri private static final String DNS_ = "DNS:"; private static final String DNS_Name_ = "DNS Name:"; + private static final String IP_ = "IP:"; + private static final String IP_Address_ = "IP Address:"; private static final String URI_ = "URI:"; private static final String RID_ = "RID:"; private static final String email_ = "email:"; private static final String dirName_ = "dirName:"; private static final String otherName_ = "otherName:"; - private static ASN1Encodable parseSubjectAltName(final String valuex) throws IOException { + private static GeneralNames parseSubjectAltName(final String valuex) throws IOException { + final String[] vals = valuex.split("(? "email:foo@bar.com,DNS:a.b.com,email:baz@bar.com", + :output => "email:foo@bar.com, DNS:a.b.com, email:baz@bar.com", + :der => "0,\x06\x03U\x1D\x11\x04%0#\x81\vfoo@bar.com\x82\aa.b.com\x81\vbaz@bar.com", + }, + { + :input => "DNS:a.b.com, email:foo@bar.com", + :der => "0\x1f\x06\x03U\x1d\x11\x04\x180\x16\x82\x07a.b.com\x81\x0bfoo@bar.com", + }, + { + :input => "URI:https://a.b.com/, DNS:a.b.com", + :der => "0$\x06\x03U\x1d\x11\x04\x1d0\x1b\x86\x10https://a.b.com/\x82\x07a.b.com", + }, + { + :input => "IP:1.2.3.4,IP: fe80::12:345:5678, email:foo@bar.com, dirName: CN=John Doe+CN=Doe\\\\\\, John\\,O=Acme", + :output => "IP:1.2.3.4, IP:fe80:0:0:0:0:12:345:5678, email:foo@bar.com, DirName:CN=John Doe+CN=Doe\\, John,O=Acme", + :der => "0f\x06\x03U\x1d\x11\x04_0]\x87\x04\x01\x02\x03\x04\x87\x10\xfe\x80\x00\x00\x00\x00\x00\x00\x00\x00\x00\x12\x03EVx\x81\x0bfoo@bar.com\xa46041#0\x0f\x06\x03U\x04\x03\x0c\x08John Doe0\x10\x06\x03U\x04\x03\x0c\x09Doe, John1\x0d0\x0b\x06\x03U\x04\x0a\x0c\x04Acme" + }, + { + :input => "RID:1.3.6.1.3.100.200", + :der => "0\x12\x06\x03U\x1d\x11\x04\x0b0\x09\x88\x07+\x06\x01\x03d\x81H", + }, + ] + extensions = OpenSSL::X509::ExtensionFactory.new - ext = extensions.create_extension("subjectAltName", "email:foo@bar.com,DNS:a.b.com,email:baz@bar.com") - assert_equal 'subjectAltName', ext.oid - assert_equal 'email:foo@bar.com, DNS:a.b.com, email:baz@bar.com', ext.value - mri_der = "0,\x06\x03U\x1D\x11\x04%0#\x81\vfoo@bar.com\x82\aa.b.com\x81\vbaz@bar.com" - assert_equal mri_der, ext.to_der + tests.each { |test| + ext = extensions.create_extension("subjectAltName", test[:input]) + assert_equal 'subjectAltName', ext.oid + assert_equal (test[:output] || test[:input]), ext.value + assert_equal test[:der], ext.to_der + } end def subject_alt_name(domains) @@ -165,4 +191,4 @@ def subject_alt_name(domains) end private :subject_alt_name -end \ No newline at end of file +end