Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow warbler to use locked jars from jar-dependencies #481

Open
mkristian opened this issue Apr 23, 2020 · 4 comments
Open

allow warbler to use locked jars from jar-dependencies #481

mkristian opened this issue Apr 23, 2020 · 4 comments

Comments

@mkristian
Copy link
Member

jar-dependencies comes bundled with jruby and superseed jbundler. jbundler and jar-dependencies are using the same Jarfile but their lock file is different. jar-dependencies uses Jars.lock

With Jars.lock present and assuming jars resolution took place - buldler install - it is just a matter of using Jars::Lock.new("Jars.lock") to info to copy the jars into the war and maybe a jars loader (probably there are a few ways to require_jar the jars from the warfile)

@mkristian
Copy link
Member Author

please on further question please ping me . . .

@headius
Copy link
Member

headius commented May 12, 2020

So basically we would switch the current logic from using JBundler to copy in the jars and instead use Jars::Lock?

@rwygand
Copy link

rwygand commented Oct 5, 2021

This is something I'd be interested in leveraging, if it's still a pending feature request.

@mkristian
Copy link
Member Author

@rwygand yes, this is still pending as:

  • jar-dependencies are shipped with jruby itself
  • jar-dependencies use the same Jarfile as jbunder, i.e. it is almost a dropin replacement
  • it makes no sense to have both jbundler and jar-dependencies as they offer the same features.

please ping me if you need help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants