Alt IPs may end up being duplicated

[MartinKolarik]

We need a repeated check here otherwise there's a race condition because of the async call that happens between the current check and actually adding the IP to the list.

[alexey-yarmosh]

Such a check already exists here, it checks alt IPs as well:

globalping/src/lib/ws/helper/probe-ip-limit.ts

Lines 30 to 53 in bee1440

	async syncIpLimit () {
	if (process.env['FAKE_PROBE_IP']) {
	return;
	}
	const probes = await this.fetchProbes();
	// Sorting probes by "client" (socket id), so all workers will treat the same probe as "first".
	const sortedProbes = _.sortBy(probes, [ 'client' ]);
	const ipToSocketId = new Map<string, string>();
	const socketIdsToDisconnect = new Set<string>();
	for (const probe of sortedProbes) {
	for (const ip of [ probe.ipAddress, ...probe.altIpAddresses ]) {
	const prevSocketId = ipToSocketId.get(ip);
	if (prevSocketId && prevSocketId !== probe.client) {
	logger.warn(`Probe ip duplication occurred (${ip}). Socket id to preserve: ${prevSocketId}, socket id to disconnect: ${probe.client}`);
	socketIdsToDisconnect.add(probe.client);
	} else {
	ipToSocketId.set(ip, probe.client);
	}
	}
	}

[MartinKolarik]

That doesn't handle duplication on the same probe. I've seen several cases where a probe had the same IP listed twice.