update tests

packages/independent/snapshot/src/side_effects/create_capture_side_effects.js

@@ -4,12 +4,17 @@ import { createReplaceFilesystemWellKnownValues } from "../filesystem_well_known
 import { filesystemSideEffects } from "./filesystem/filesystem_side_effects.js";
 import { logSideEffects } from "./log/log_side_effects.js";
 
+const executionEffectsDefault = {
+  catch: true,
+  return: true,
+};
+
 export const createCaptureSideEffects = ({
   sourceFileUrl,
   logEffects = true,
   filesystemEffects = true,
   filesystemActions,
-  executionEffects = {},
+  executionEffects = executionEffectsDefault,
   rootDirectoryUrl,
   replaceFilesystemWellKnownValues = createReplaceFilesystemWellKnownValues({
     rootDirectoryUrl,
@@ -21,6 +26,7 @@ export const createCaptureSideEffects = ({
       return: false,
     };
   }
+  executionEffects = { ...executionEffectsDefault, ...executionEffects };
 
   const detectors = [];
   if (logEffects) {

packages/independent/snapshot/tests/snapshot_side_effects/advanced/side_effects_advanced.test.mjs

@@ -138,6 +138,7 @@ import { snapshotSideEffects } from "@jsenv/snapshot";
       throw new Error("in the end we throw");
     },
     {
+      executionEffects: { catch: true },
       sideEffectMdFileUrl: new URL(
         "./output/6_console_and_file.md",
         import.meta.url,

packages/independent/snapshot/tests/snapshot_tests/file_then_throw/file_then_throw.test.mjs

@@ -26,6 +26,7 @@ await snapshotTests(
     });
   },
   {
+    executionEffects: { catch: true },
     outFilePattern: "./git_ignored/[filename]",
   },
 );
@@ -46,6 +47,7 @@ await snapshotSideEffects(
           });
         },
         {
+          executionEffect: { catch: true },
           throwWhenDiff: true,
           outFilePattern: "./git_ignored/[filename]",
         },

packages/related/plugin-preact/tests/script_module_jsx_error/script_module_jsx_error_dev.test.mjs

@@ -14,6 +14,12 @@ const run = async ({ browserLauncher }) => {
   });
 };
 
-await snapshotDevSideEffects(import.meta.url, ({ test }) => {
-  test("0_chromium", () => run({ browserLauncher: chromium }));
-});
+await snapshotDevSideEffects(
+  import.meta.url,
+  ({ test }) => {
+    test("0_chromium", () => run({ browserLauncher: chromium }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

packages/related/test/tests/execution/js_assertion_error/js_assertion_error_browsers.test.mjs

@@ -26,19 +26,25 @@ const run = async ({ runtime }) => {
   });
 };
 
-await snapshotFileExecutionSideEffects(import.meta.url, async ({ test }) => {
-  test("0_chromium", () =>
-    run({
-      runtime: chromium(),
-    }));
-  test("1_firefox", () =>
-    run({
-      runtime: firefox({
-        disableOnWindowsBecauseFlaky: false,
-      }),
-    }));
-  test("2_webkit", () =>
-    run({
-      runtime: webkit(),
-    }));
-});
+await snapshotFileExecutionSideEffects(
+  import.meta.url,
+  async ({ test }) => {
+    test("0_chromium", () =>
+      run({
+        runtime: chromium(),
+      }));
+    test("1_firefox", () =>
+      run({
+        runtime: firefox({
+          disableOnWindowsBecauseFlaky: false,
+        }),
+      }));
+    test("2_webkit", () =>
+      run({
+        runtime: webkit(),
+      }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

packages/related/test/tests/execution/js_assertion_error/js_assertion_error_node.test.mjs

@@ -11,13 +11,19 @@ const run = async ({ runtime }) => {
   });
 };
 
-await snapshotFileExecutionSideEffects(import.meta.url, async ({ test }) => {
-  test("0_worker_thread", () =>
-    run({
-      runtime: nodeWorkerThread(),
-    }));
-  test("0_child_process", () =>
-    run({
-      runtime: nodeChildProcess(),
-    }));
-});
+await snapshotFileExecutionSideEffects(
+  import.meta.url,
+  async ({ test }) => {
+    test("0_worker_thread", () =>
+      run({
+        runtime: nodeWorkerThread(),
+      }));
+    test("0_child_process", () =>
+      run({
+        runtime: nodeChildProcess(),
+      }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

packages/related/test/tests/execution/js_syntax_error/js_syntax_error_browsers.test.mjs

@@ -19,17 +19,23 @@ const run = async ({ runtime }) => {
   });
 };
 
-await snapshotFileExecutionSideEffects(import.meta.url, async ({ test }) => {
-  test("0_chromium", () =>
-    run({
-      runtime: chromium(),
-    }));
-  test("1_firefox", () =>
-    run({
-      runtime: firefox({ disableOnWindowsBecauseFlaky: false }),
-    }));
-  test("2_webkit", () =>
-    run({
-      runtime: webkit(),
-    }));
-});
+await snapshotFileExecutionSideEffects(
+  import.meta.url,
+  async ({ test }) => {
+    test("0_chromium", () =>
+      run({
+        runtime: chromium(),
+      }));
+    test("1_firefox", () =>
+      run({
+        runtime: firefox({ disableOnWindowsBecauseFlaky: false }),
+      }));
+    test("2_webkit", () =>
+      run({
+        runtime: webkit(),
+      }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

packages/related/test/tests/snapshot_execution_side_effects.js

@@ -6,11 +6,15 @@ export const snapshotFileExecutionSideEffects = async (
   options = {},
 ) =>
   snapshotTests(testFileUrl, fnRegisteringTests, {
+    ...options,
     filesystemActions: {
       "**": "compare",
       "**/.jsenv/": "undo",
     },
-    ...options,
+    executionEffects: {
+      catch: false,
+      ...options.executionEffects,
+    },
   });
 
 export const snapshotTestPlanSideEffects = async (
@@ -19,12 +23,16 @@ export const snapshotTestPlanSideEffects = async (
   options = {},
 ) =>
   snapshotTests(testFileUrl, fnRegisteringTests, {
+    ...options,
     filesystemActions: {
       "**": "compare",
       "**/.jsenv/": "undo",
       "**/*.png": process.env.CI ? "compare_presence_only" : "compare",
       "**/*.gif": "ignore",
       "**/.coverage/": "ignore",
     },
-    ...options,
+    executionEffects: {
+      catch: false,
+      ...options.executionEffects,
+    },
   });

tests/dev_and_build/errors/js_export_missing/_js_export_missing_dev.test.mjs/0_chromium/0_chromium.md

@@ -1,4 +1,4 @@
-# [0_chromium](../../js_export_missing_dev.test.mjs#L26)
+# [0_chromium](../../js_export_missing_dev.test.mjs#L28)
 
 ```js
 run({ browserLauncher: chromium })

tests/dev_and_build/errors/js_export_missing/js_export_missing_dev.test.mjs

@@ -22,6 +22,12 @@ const run = async () => {
   });
 };
 
-await snapshotDevSideEffects(import.meta.url, ({ test }) => {
-  test("0_chromium", () => run({ browserLauncher: chromium }));
-});
+await snapshotDevSideEffects(
+  import.meta.url,
+  ({ test }) => {
+    test("0_chromium", () => run({ browserLauncher: chromium }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

tests/dev_and_build/errors/js_syntax_error/_js_syntax_error_dev.test.mjs/0_chromium/0_chromium.md

@@ -1,4 +1,4 @@
-# [0_chromium](../../js_syntax_error_dev.test.mjs#L26)
+# [0_chromium](../../js_syntax_error_dev.test.mjs#L28)
 
 ```js
 run({ browserLauncher: chromium })

tests/dev_and_build/errors/js_syntax_error/js_syntax_error_dev.test.mjs

@@ -22,6 +22,12 @@ const run = async () => {
   });
 };
 
-await snapshotDevSideEffects(import.meta.url, ({ test }) => {
-  test("0_chromium", () => run({ browserLauncher: chromium }));
-});
+await snapshotDevSideEffects(
+  import.meta.url,
+  ({ test }) => {
+    test("0_chromium", () => run({ browserLauncher: chromium }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

tests/dev_and_build/errors/js_throw/_js_throw_dev.test.mjs/0_chromium/0_chromium.md

@@ -1,4 +1,4 @@
-# [0_chromium](../../js_throw_dev.test.mjs#L26)
+# [0_chromium](../../js_throw_dev.test.mjs#L28)
 
 ```js
 run({ browserLauncher: chromium })

tests/dev_and_build/errors/js_throw/js_throw_dev.test.mjs

@@ -22,6 +22,12 @@ const run = async () => {
   });
 };
 
-await snapshotDevSideEffects(import.meta.url, ({ test }) => {
-  test("0_chromium", () => run({ browserLauncher: chromium }));
-});
+await snapshotDevSideEffects(
+  import.meta.url,
+  ({ test }) => {
+    test("0_chromium", () => run({ browserLauncher: chromium }));
+  },
+  {
+    executionEffects: { catch: true },
+  },
+);

tests/snapshot_build_side_effects.js

@@ -20,4 +20,8 @@ export const snapshotBuildTests = async (
             level: "warn",
             ...(options.logEffects === true ? {} : options.logEffects),
           },
+    executionEffects: {
+      catch: false,
+      ...options.executionEffects,
+    },
   });

tests/snapshot_dev_side_effects.js

@@ -21,4 +21,8 @@ export const snapshotDevSideEffects = async (
             level: "warn",
             ...(options.logEffects === true ? {} : options.logEffects),
           },
+    executionEffects: {
+      catch: false,
+      ...options.executionEffects,
+    },
   });