Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash in filenames #442

Merged
merged 10 commits into from
Nov 24, 2024
Merged

Fix hash in filenames #442

merged 10 commits into from
Nov 24, 2024

Conversation

dmail
Copy link
Member

@dmail dmail commented Nov 24, 2024

No description provided.

Copy link

github-actions bot commented Nov 24, 2024

File size impact

Impact on file sizes when merging fix_hash_in_filenames into main.

dist (+0.3%)
Files new size new gzip size
dist/jsenv_core.js 705 kB (+2.9 kB / +0.4%) 156 kB (+207 B / +0.1%) ↗️
Unmodified (115) 449 kB (0 B / +0%) 123 kB (0 B / +0%) 👻
Total (116) 1.2 MB (+2.9 kB / +0.3%) 279 kB (+207 B / +0.07%) ↗️
Generated by @jsenv/file-size-impact during file size impact#11999960694 on e9bdfb8

Copy link

github-actions bot commented Nov 24, 2024

Performance impact

Impact on 38 metrics when merging fix_hash_in_filenames into main. Before drawing conclusion, keep in mind performance variability.

package metrics (-0.2%)
Metric Before merge After merge Impact
import duration 0.09 second 0.09 second -0.002 second / -2% ↘️
import memory heap used 6.3 MB 6.3 MB +15.6 kB / +0.2% ↗️
import memory heap total 15.1 MB 15.1 MB +12.3 kB / +0.08% ↗️
import fs open operations 75 75 👻
import fs stat operations 145 145 👻
npm tarball size 342 kB 342 kB +223 B / +0.07% ↗️
npm tarball unpacked size 1.6 MB 1.6 MB +3 kB / +0.2% ↗️
npm tarball file count 206 206 👻
dev server metrics (+3%)
Metric Before merge After merge Impact
start duration 0.1 second 0.1 second +0.001 second / +0.9% ↗️
start memory heap used 6.7 MB 6.8 MB +32 kB / +0.5% ↗️
start memory heap total 23.5 MB 23.5 MB +12.3 kB / +0.05% ↗️
start fs read 0 0 👻
start fs write 0 0 👻
time to app display 0.5 second 0.5 second -0.008 second / -2% ↘️
serve app memory heap total 19.5 MB 19 MB -520 kB / -3% ↘️
serve app memory heap used 16.6 MB 16.6 MB -4.5 kB / -0.03% ↘️
serve app fs read 0 0 👻
serve app fs write 888 888 👻
time to 2nd app display 0.2 second 0.2 second -0.006 second / -3% ↘️
2nd serve memory heap total 2.4 MB 3.1 MB +786 kB / +33% ↗️
2nd serve memory heap used 691 kB 708 kB +16.8 kB / +2% ↗️
2nd serve fs read 0 0 👻
2nd serve fs write 888 888 👻
build metrics (-0.2%)
Metric Before merge After merge Impact
build duration 0.8 second 0.8 second -0.01 second / -1% ↘️
build memory heap used 32.8 MB 32.8 MB +30.6 kB / +0.09% ↗️
build memory heap total 66.1 MB 66.4 MB +279 kB / +0.4% ↗️
number of fs read operation 0 0 👻
number of fs write operation 264 264 👻
test metrics (-0.5%)
Metric Before merge After merge Impact
test plan duration 3.1 seconds 3 seconds -0.1 second / -3% ↘️
test plan memory heap used 43.1 MB 43.1 MB +45.6 kB / +0.1% ↗️
test plan memory heap total 86.4 MB 87.4 MB +1.1 MB / +1% ↗️
number of fs read operation 0 0 👻
number of fs write operation 1656 1656 👻
test metrics (serie) (+0.2%)
Metric Before merge After merge Impact
test plan duration 3.6 seconds 3.6 seconds -0.01 second / -0.4% ↘️
test plan memory heap used 43.2 MB 43.2 MB +11.8 kB / +0.03% ↗️
test plan memory heap total 86.4 MB 87.4 MB +1.1 MB / +1% ↗️
number of fs read operation 0 0 👻
number of fs write operation 1656 1656 👻
Generated by @jsenv/performance-impact during performance_impact#11999960698 on e9bdfb8

@dmail dmail marked this pull request as ready for review November 24, 2024 22:04
@dmail dmail merged commit 6d29fda into main Nov 24, 2024
5 of 8 checks passed
@dmail dmail deleted the fix_hash_in_filenames branch November 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant