Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: optimize distance calculations at different tax levels #20

Open
jsevo opened this issue Apr 28, 2022 · 1 comment
Open

TODO: optimize distance calculations at different tax levels #20

jsevo opened this issue Apr 28, 2022 · 1 comment

Comments

@jsevo
Copy link
Owner

jsevo commented Apr 28, 2022

When using cityblock, we won't have to do what's happening here:

def tax_agg(rel_abundances, taxonomy, agg_levels, distance_metric, weights):

The distances can be calculated at ASV level and then the columns of distance matrices can be added based on taxonomy. This distance works, maybe others too.

@jsevo
Copy link
Owner Author

jsevo commented Apr 29, 2022

Another optimization that is easily possible: allow the user to provide a pre-calculated distance; overall distance or per taxonomic level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant