Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump credo from 1.6.7 to 1.7.0 #1913

Closed
wants to merge 1 commit into from
Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2023

Bumps credo from 1.6.7 to 1.7.0.

Changelog

Sourced from credo's changelog.

1.7.0

  • Credo.Check.Readability.ModuleDoc works for Phoenix 1.7+ views
  • Credo.Check.Readability.FunctionNames now ignores custom operators
  • Credo.Check.Refactor.Apply now works in pipes
  • Credo.Check.Consistency.ExceptionNames does no longer yield an issue if there is only one match
  • Credo.Check.Readability.ModuleNames now supports an :ignore parameter
  • Credo.Check.Design.AliasUsage now supports an :if_referenced parameter
  • Credo.Check.Readability.FunctionNames now works for acronyms in predicate functions
  • Credo.Check.Readability.NestedFunctionCalls now works for calls already in a pipeline and local function calls

Add SARIF support

Credo 1.7 provides a formatter that will output data in SARIF format, allowing direct GitHub support via the Security tab.

You can now use mix credo --format=sarif to output results in SARIF format.

Add IDs to checks

This was requested for SARIF support and has been added to provide a unique identifier for checks that is more technical than the check name.

Check authors can add IDs to their custom checks by using the :id option:

defmodule MyCheck do
  use Credo.Check,
    id: "EX5042",
    category: :warning,
    # ...
end

Credo's naming scheme for these IDs is simple:

EX5042
^^

EX stands for Elixir.

EX5042
  ^

The first digit represents the category.

EX5042
   ^

... (truncated)

Commits
  • 4a3d1ef Bump version to 1.7.0
  • 3d8aad3 Update CHANGELOG
  • fe6ee79 Merge pull request #1020 from Stratus3D/tb/nested-calls-check-fix
  • 5cfea9e Duplicate code into NestedFunctionCalls check module
  • b8583dc Revert "Extract valid_chain_start?/3 pipe helper function into helper module"
  • ab49200 Update compatibility-phoenix.yml
  • 5c25cd8 Fix Nesting issues with non-do blocks
  • c5155c0 Update compatibility-phoenix.yml
  • be3422d Fix issue with else blocks in Nesting
  • 0b2ff85 Add test reproducing #1029
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code labels Mar 21, 2023
@cla-bot cla-bot bot added the cla-signed label Mar 21, 2023
@github-actions github-actions bot enabled auto-merge (squash) March 21, 2023 08:02
@github-advanced-security
Copy link

You have successfully added a new Sobelow configuration .github/workflows/pr.yml:sobelow. As part of the setup process, we have scanned this repository and found 4 existing alerts. Please check the repository Security tab to see all alerts.

@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from 3de221b to da87270 Compare March 21, 2023 08:15
@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from da87270 to 0da977e Compare March 21, 2023 10:27
@coveralls
Copy link

Coverage Status

Coverage: 53.133%. Remained the same when pulling 0da977e on dependabot/hex/credo-1.7.0 into 61f63ff on main.

@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from 0da977e to 35a0b24 Compare March 23, 2023 08:17
@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from 35a0b24 to d0d3f37 Compare March 24, 2023 08:20
@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from d0d3f37 to df720be Compare March 28, 2023 08:14
@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from df720be to 2a26b93 Compare April 10, 2023 08:13
Bumps [credo](https://github.com/rrrene/credo) from 1.6.7 to 1.7.0.
- [Release notes](https://github.com/rrrene/credo/releases)
- [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md)
- [Commits](rrrene/credo@v1.6.7...v1.7.0)

---
updated-dependencies:
- dependency-name: credo
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/hex/credo-1.7.0 branch from 2a26b93 to 146c30c Compare April 10, 2023 08:34
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2023

Superseded by #2028.

@dependabot dependabot bot closed this Oct 2, 2023
auto-merge was automatically disabled October 2, 2023 08:03

Pull request was closed

@dependabot dependabot bot deleted the dependabot/hex/credo-1.7.0 branch October 2, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dependencies Pull requests that update a dependency file elixir Pull requests that update Elixir code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant