Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B1 Review #12

Open
jshreyans opened this issue Dec 20, 2018 · 2 comments
Open

B1 Review #12

jshreyans opened this issue Dec 20, 2018 · 2 comments
Assignees

Comments

@jshreyans
Copy link
Owner

Completed B1
Will be adding more animations on keydown and keyup to highlight what key has been pressed

@sarthak-sehgal
Copy link
Collaborator

@jshreyans551 have a look at the task description again
"Clicking on these 'virtual keys' or pressing the corresponding keys on the keyboard should produce a sound (different sounds for different keys)."

@jshreyans
Copy link
Owner Author

@sarthak-sehgal
I've added the necessary code for mouseclicks also. However, I had to use the switch-case again and that makes the code repetetive. I'm trying to make a function and simply call it in both mousedown and keydown but the switch receives different argument types in each event so that creates a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants