Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A5 Review #6

Open
jshreyans opened this issue Dec 17, 2018 · 4 comments
Open

A5 Review #6

jshreyans opened this issue Dec 17, 2018 · 4 comments
Assignees
@sarthak-sehgal @kunal-mohta @LakshSingla

Comments

@jshreyans
Copy link
Owner

Resolved alignment problem with box button and completed A5
@kunal-mohta
Copy link
Collaborator

Something went wrong in firefox browser. The buttons are stuck on top of the window.
You should make a habit to run your html on multiple browsers (chrome and firefox are the standard ones to try on)

jshreyans added a commit that referenced this issue Dec 22, 2018
@jshreyans
Corrected A5 as per #6
87bb043
@jshreyans
Copy link
Owner Author

The height of body was not set so Firefox showed body to be 1436x0. I've set it to 100vh. Don't know how it was working for Chrome though.

@ccpandhare
Copy link

551106be-7a6e-4e89-b409-b2ccfcfd2222

Had some weird issues on Safari (iOS)
Do have a look

@jshreyans
Copy link
Owner Author

@ccpandhare
I'll try to correct the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarthak-sehgal sarthak-sehgal

@kunal-mohta kunal-mohta

@LakshSingla LakshSingla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ccpandhare @sarthak-sehgal @kunal-mohta @LakshSingla @jshreyans