Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move draft-specific files to the dedicated dir for its draft #753

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

karenetheridge
Copy link
Member

@karenetheridge karenetheridge commented Oct 7, 2024

..otherwise, draft-specific test suites won't know to skip adding the file

@karenetheridge karenetheridge requested a review from a team as a code owner October 7, 2024 21:01
@karenetheridge karenetheridge marked this pull request as draft October 8, 2024 17:10
@karenetheridge karenetheridge force-pushed the ether/fix-draft-locations branch 2 times, most recently from 8f5a987 to 96bc1ec Compare October 8, 2024 17:22
@karenetheridge karenetheridge changed the title move draft4-specific file to dedicated dir for this draft, and add $schema move draft-specific files to the dedicated dir for its draft Oct 8, 2024
@karenetheridge karenetheridge marked this pull request as ready for review October 8, 2024 17:23
@karenetheridge
Copy link
Member Author

Rebased, and also copied the draft6 and draft7 versions of this file.

All the remaining files in remotes/ that aren't in a draft-specific directory are compatible with draft2020-12, the latest published version. If we introduce other incompatibilties in the future we may need to move around some other files so they don't get used by the wrong versions.

@karenetheridge karenetheridge marked this pull request as draft October 8, 2024 17:26
..otherwise, draft-specific test suites won't know to skip adding the file
@karenetheridge karenetheridge marked this pull request as ready for review October 8, 2024 18:01
Copy link
Contributor

@notEthan notEthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break anything for me

@karenetheridge karenetheridge merged commit 82a0774 into main Oct 9, 2024
4 checks passed
@karenetheridge karenetheridge deleted the ether/fix-draft-locations branch October 9, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants