Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform disallow from Draft 3 to Draft 4 #38

Merged
merged 16 commits into from
Aug 5, 2024
Merged

Conversation

suprith-hub
Copy link
Collaborator

No description provided.

@suprith-hub suprith-hub changed the title Draft3 4disallowrefactor Draft3 to 4 :disallow Refactor Aug 3, 2024
@suprith-hub
Copy link
Collaborator Author

@jviotti shall I include tests the same way for 2019 to 2020 and draft 7 to 2019 too?
Tests related to single keyword all in a single file?

@jviotti
Copy link
Member

jviotti commented Aug 5, 2024

As mentioned in the other PR, try to write better PR titles. "Draft3 to 4 :disallow Refactor" is poorly written. You probably want a space before "3", I don't know why disallow is prefixed by ":", why disallow is not in backticks, and why "Refactor" is capitalised. PR titles are important! Don't just write them fast

@jviotti
Copy link
Member

jviotti commented Aug 5, 2024

@jviotti shall I include tests the same way for 2019 to 2020 and draft 7 to 2019 too?
Tests related to single keyword all in a single file?

Yeah, that makes sense!

@jviotti jviotti changed the title Draft3 to 4 :disallow Refactor Transform disallow from Draft 3 to Draft 4 Aug 5, 2024
@jviotti jviotti merged commit bbc0d70 into main Aug 5, 2024
1 check passed
@jviotti jviotti deleted the draft3-4disallowrefactor branch August 5, 2024 14:21
suprith-hub added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants