Draft 2 to 3, rules on optional, requires keyword
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
reviewed
Aug 7, 2024
| }, | ||
| "to": { | ||
| "properties": { | ||
| "foo": {}, |
There was a problem hiding this comment.
The test is definitely valid, but I wonder if we should get rid of these empty properties. No reason to artificially add them, right?
There was a problem hiding this comment.
Okay, i'll have to add rules for whose dependent rule is popping properties..
There was a problem hiding this comment.
@jviotti but there can be references to #/properties/foo, #/propeties/bar etc.. even though they are empty. So, I think we shouldn't remove them
There was a problem hiding this comment.
Right. OK, fine to keep them then!
jviotti
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.