Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📝 Docs]: Formatting issues in example on Regular Expressions page #1140

Closed
1 task done
Vaent opened this issue Nov 25, 2024 · 2 comments · Fixed by #1115
Closed
1 task done

[📝 Docs]: Formatting issues in example on Regular Expressions page #1140

Vaent opened this issue Nov 25, 2024 · 2 comments · Fixed by #1115
Assignees
Labels
📝 Documentation Indicates improvements or additions to documentation. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Vaent
Copy link
Contributor

Vaent commented Nov 25, 2024

What Docs changes are you proposing?

The page at https://json-schema.org/understanding-json-schema/reference/regular_expressions contains two examples.

The first example (North American telephone number) identifies the schema and identifies whether or not each data sample complies with the schema.

The second example (string wrapped in curly braces permitting newlines) presents the schema as a data sample and doesn't identify which of the actual data samples would be compliant.

I've opened pull request #1115 to format the second example like the first if this issue is accepted (thanks @gregsdennis for the steer!)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Vaent Vaent added Status: Triage This is the initial status for an issue that requires triage. 📝 Documentation Indicates improvements or additions to documentation. labels Nov 25, 2024
@29deepanshutyagi
Copy link
Contributor

29deepanshutyagi commented Dec 23, 2024

i want to work on this issue , kindly assign me @Vaent

@kurtmckee
Copy link
Contributor

@29deepanshutyagi The reporter noted in their original, unedited post that they had already opened a PR for this; there is no need to try to work on this.

More relevant to me, however, is that you @-mentioned me unnecessarily -- I have no rights on this repository. Please be far more cautious who you @-mention when posting.

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Indicates improvements or additions to documentation. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants