Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build main-eisop #211

Open
netdpb opened this issue Oct 28, 2024 · 2 comments
Open

Can't build main-eisop #211

netdpb opened this issue Oct 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@netdpb
Copy link
Collaborator

netdpb commented Oct 28, 2024

I'm getting a failure to build the main-eisop branch on a brand-new clone.

$ ls -a
total 8
4 ./  4 ../
$ git clone [email protected]:jspecify/jspecify-reference-checker.git
Cloning into 'jspecify-reference-checker'...
remote: Enumerating objects: 4032, done.
remote: Counting objects: 100% (660/660), done.
remote: Compressing objects: 100% (249/249), done.
remote: Total 4032 (delta 375), reused 520 (delta 291), pack-reused 3372 (from 1)
Receiving objects: 100% (4032/4032), 996.26 KiB | 29.30 MiB/s, done.
Resolving deltas: 100% (1426/1426), done.
$ cd jspecify-reference-checker/
$ git checkout main-eisop 
branch 'main-eisop' set up to track 'origin/main-eisop'.
Switched to a new branch 'main-eisop'
$ ./gradlew build
git clone --depth 1 --single-branch https://github.com/jspecify/jdk.git ../jdk 
Cloning into '../jdk'...
Updating files: 100% (69213/69213)
Updating files: 100% (69213/69213), done.

> Task :compileJava FAILED
/usr/local/google/home/dpb/dev/jspecify-eisop/jspecify-reference-checker/src/main/java/com/google/jspecify/nullness/NullSpecAnnotatedTypeFactory.java:110: error: cannot find symbol
import org.checkerframework.framework.util.NoContractsFromMethod;
                                          ^
  symbol:   class NoContractsFromMethod
  location: package org.checkerframework.framework.util
/usr/local/google/home/dpb/dev/jspecify-eisop/jspecify-reference-checker/src/main/java/com/google/jspecify/nullness/NullSpecAnnotatedTypeFactory.java:1038: error: cannot find symbol
    return new NoContractsFromMethod();
               ^
  symbol:   class NoContractsFromMethod
  location: class NullSpecAnnotatedTypeFactory
/usr/local/google/home/dpb/dev/jspecify-eisop/jspecify-reference-checker/src/main/java/com/google/jspecify/nullness/NullSpecChecker.java:72: error: method does not override or implement a method from a supertype
  @Override
  ^
3 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.
> Run with --scan to get full insights.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.10/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 32s
1 actionable task: 1 executed
@netdpb netdpb added the bug Something isn't working label Oct 28, 2024
@wmdietl
Copy link
Collaborator

wmdietl commented Oct 28, 2024

You need to clone eisop/checker-framework and include that build, see

run: ./gradlew build conformanceTests demoTest --include-build ../jspecify --include-build ../checker-framework

I'll make an EISOP release next week, then the reference checker will work with that release.

@cpovirk
Copy link
Collaborator

cpovirk commented Oct 30, 2024

I think I had mentioned my steps in jspecify/jspecify#583 (review) elsewhere, so that's at least something that might still unblock your attempt until the normal instructions are fixed by a release or whatever turns out to be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants