Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checker for #248 substitution decision #212

Open
cpovirk opened this issue Nov 5, 2024 · 0 comments
Open

Update checker for #248 substitution decision #212

cpovirk opened this issue Nov 5, 2024 · 0 comments

Comments

@cpovirk
Copy link
Collaborator

cpovirk commented Nov 5, 2024

I have a note that I saw what looked like a related problem in build 017dc798-8948-4391-8614-d59a2b2f7c43. It happened when Map.merge had an unspecified-nullness parameter for V value under J2CL and some Guava code naturally had @NonNull V value. A non-null subclass parameter should be considered valid when overriding a method with an unspecified superclass parameter.

I also have a note that either I thought it might be related to #193 or just that I figured #193 was another thing that I should look into at the same time.

The two do seem plausibly related and might even be fixed by my internal CL 664839751, which implements at least some of the changes of jspecify/jspecify#248 (hopefully all of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant