Ensure root is set in both worlds. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(The assertion violation was silently ignored in a few test cases. As it is no longer needed, remove it.)
…hecker into issue-159-again
Merged
cpovirk
approved these changes
Apr 16, 2024
| withMostConvenientWorld.setRoot(root); | ||
| } | ||
| } | ||
| settingRoot = false; |
There was a problem hiding this comment.
I might have expected for this to appear inside the if so that that block both sets to true and sets to false. That would also mean that, if someone tried to call setRoot twice while a call was already active, then it would still be a no-op.
But I see no reason to think that the current code is a problem.
There was a problem hiding this comment.
Yes, definitely nicer in the block. I've moved the assignment.
|
I've confirmed that this fixes the crashes from my testing in the Google depot. |
…hecker into issue-159-again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159, for real, hopefully.
This PR contains all changes in #173, so review and merge that first.