Virtual chin rest plugin #975

GEJ1 · 2020-08-13T20:50:18Z

GEJ1
Aug 13, 2020

Hi everyone,

I was working on wraping up the code from virtual chin rest (paper: Qisheng Li et al., 2020) into a plugin, and I think I have a first version that works.

Thank you @jodeleeuw for your super useful youtube video about making plugins: https://youtu.be/XQcsFwAmbiw

If anyone is interested in making improvements:

code : https://github.com/GEJ1/jsPsych_online_TMT/blob/master/jspsych/plugins/jspsych-virtual-chin.js
external JS/CSS for using jquery and stimulus : https://drive.google.com/drive/folders/1CP8Cg1xbzILPxejGEXtpLDHQuPxkxFF6?usp=sharing

I used the same external files that the original JavaScript code: https://github.com/QishengLi/virtual_chinrest

Uploaded in cognition.run: https://9s6ib7pmqv.cognition.run/

ps: Maybe theres is some comments in spanish, sorry hehe.

Best!

Gustavo.

Stajduhar-A · 2020-08-13T21:00:10Z

Stajduhar-A
Aug 13, 2020

Very interesting and would love to check it out but I'm greeted with this when I try to view it on cognition.run...

2 replies

GEJ1 Aug 13, 2020
Author

Ohh, maybe is the browser? It works for me on Google Chrome

jodeleeuw Aug 14, 2020
Maintainer

Worked for me on Chrome as well.

jodeleeuw · 2020-08-14T15:51:19Z

jodeleeuw
Aug 14, 2020
Maintainer

This is great! If you are willing to write documentation and create an example for using the plugin we can incorporate it into a future release. You could open a Pull Request to merge this in. We can also work on the documentation and example ourselves, but that'll be slower.

We may also want to consider merging some of this work with the jspsych-resize plugin. That plugin does the same work as the first part of the chinrest script, so it would make sense to get rid of the resize plugin and combine these together, perhaps making the blind spot detection part of the task optional.

2 replies

GEJ1 Aug 16, 2020
Author

Thank you @jodeleeuw ! I'll be glad to contribute making a Pull Request.

GEJ1 Aug 31, 2020
Author

I just opened a Pull Request: #1024

yuvalharr · 2020-08-31T15:02:08Z

yuvalharr
Aug 31, 2020

Thats great Gustavo, thank you very much! I just found the original paper and code and hoped so much that someone would be able to make it into a plugin :)

Does your plugin allow to take the scale from the credit card and use it as a measure to resize the rest of the experiment into a certain size, like the Resize plugin?

Anyway, this plugin looks amazing, so thanks again!

Yuval

3 replies

GEJ1 Aug 31, 2020
Author

Thank you! The plugin is not doing the resize at this moment. My interim solution is to use the jsPsych-resize plugin before the virtual chin in order to resize the screen.

As @jodeleeuw mention, it would be a good idea to merge the virtual chin and the resize plugins.

yuvalharr Sep 1, 2020

Thanks for the answer!

So you mean to do twice a credit card measuring- each in every trial? Or were you able to pass the data of the measure from the resize plugin into the virtual chin plugin without the need to make participants measure their card again?

GEJ1 Sep 25, 2020
Author

Yes, I mean to do twice a credit card measuring, using first the jsPsych-resize plugin. Doing that at beginning of the experiment it's enough.

QishengLi · 2020-08-31T19:52:04Z

QishengLi
Aug 31, 2020

@GEJ1 Thanks for your interest in our work and making effort to convert it to a jsPsych plugin! Please let me know how I can help - I am happy to review/contribute to the pull request.

Best,
Qisheng

1 reply

GEJ1 Aug 31, 2020
Author

Thank you @QishengLi ! I think it is a really useful tool what you made. I'll be posting here the news about the plugin in order to colaborate.

Best,

Gustavo.

jodeleeuw · 2020-09-01T01:28:29Z

jodeleeuw
Sep 1, 2020
Maintainer

Thanks for opening the pull request!

I do think it would be worth merging some of the resize plugin features into this, like being able to select the object size for scaling and having the rest of the experiment scaled to a particular size. We should probably also make the text configurable so it can be used in other languages. One way to do this is to make the instructions for using the plugin a parameter.

Other really useful things for the pull request would be:

updates to the documentation
an example in the examples folder
tests in the tests folder as appropriate
updates to the contributors.md file in the main folder

We should make sure that the documentation page links to @QishengLi 's paper and provides the appropriate citation info. The documentation for the RDK plugin is a nice example of this.

0 replies

yuvalharr · 2020-09-01T12:56:12Z

yuvalharr
Sep 1, 2020

Sorry for the many questions, but I still have some issues.

After the virtual chinrest plugin is over, it doesn't continue to the next trial (which is an html-keyboard-response trial). It instead shows an error message right after pressing the space bar:

jspsych-html-keyboard-response.js:109 Uncaught TypeError: Cannot read property 'className' of null
at Object.after_response [as callback_function] (jspsych-html-keyboard-response.js:109)
at Object.listener_function [as fn] (jspsych.js:2064)
at HTMLBodyElement.root_keydown_listener (jspsych.js:1983)

Couldn't manage to understand what might cause this, as it is working fine without the chinrest plugin. My best guess is something to do with the additional css files that I might didn't use them right.

Here is part of my html page where I put all of the files you provided with the plugin:

    <script src="jspsych-6.1.0/plugins/jspsych-virtual-chin.js"></script>
    <script src= "jspsych-6.1.0/jquery.min.js"></script>
    <script src= "jspsych-6.1.0/jquery-ui.min.js"></script>
    <script src= "jspsych-6.1.0/svg.min.js"></script>
    <link href="jspsych-6.1.0/css/jspsych.css" rel="stylesheet" type="text/css"></link>
    <link href="jspsych-6.1.0/css/bootstrap.min.css" rel="stylesheet" type="text/css"></link> 
    <link href="jspsych-6.1.0/css/jquery-ui.css" rel="stylesheet" type="text/css"></link>
    <link href="jspsych-6.1.0/css/styles.css" rel="stylesheet" type="text/css"></link>

Does it look OK? Any ideas to what might be the problem?

Thanks very much,
Yuval

3 replies

GEJ1 Sep 25, 2020
Author

Hi @yuvalharr , sorry for the delay. I made a commit today and I think now it's fixed, please tell me if not: https://github.com/GEJ1/jsPsych/blob/master/plugins/jspsych-virtual-chin-rest.js

The functionality for going to next trial was working weird, in my experiment was working but I think know works with every plugin at next.

Best!

Gustavo.

yuvalharr Sep 29, 2020

Hi, thank you for your time and effort!

Actually I've tried your fix but it still has some problems... In my experiment, after the chin-rest trial it goes to an html-keyboard-response trial, which should include several html texts one after the other, advancing to the next message after every space bar press. The problem is that it gets stuck at the first stimulus, and pressing the space bar doesn't work in order to advance to the next html-keyboard-response stimulus.

At this point I've actually found a fix that was OK for me. I just put a different trail that turns out to work (animation), for only milliseconds, right after your chin-rest trial. Turns out that when putting it between the chin-rest and the html-keyboard-response it makes the html-keyboard-response trial work well. So don't bother for me, it works good for me now :)

Again, thank you very much for your help and for this great plugin!

Yuval

GEJ1 Sep 29, 2020
Author

Excellent! Tell thanks to @QishengLi , she made the plugin, I'm just helping to put it in the jsPsych structure. Hope we can make it available as a well-functioning plugin soon.

If anyone wants to contribute, I already opened a pull request with the code and the documentation: #1024

Best! :)

Gustavo.

pjkohler · 2021-01-19T04:51:07Z

pjkohler
Jan 19, 2021

Hi Gustavo,

I had somehow missed your implementation so spent some time today making my own. It looks like we've taken pretty similar strategies when implementing @QishengLi's code. I was mainly trying to touch as little of that code as possible, and then simply build a JsPsych plug-in around it. My main interest is having a self-contained plugin that can give me the viewing distance and px2mm, which I can then use to compute approximate px2deg. I am not so interested in having resizing built into the function, as I find it more useful to define the size of individual display elements in physical units. Would you allow me to contribute to your plugin, and if so how do I go about it?

Best,

Peter

10 replies

jodeleeuw Jan 26, 2021
Maintainer

Happy to help as needed!

GEJ1 Jan 26, 2021
Author

Thank you @jodeleeuw !

@pjkohler: I have no problem if you want to push my existing fork, but if it's easier for you to create a new one, feel free to do so. I agree that incorporating the resize plugin may not be so straightforward.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtual chin rest plugin #975

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 7 comments 21 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Virtual chin rest plugin #975

Replies: 7 comments · 21 replies

GEJ1 Aug 13, 2020 Author

jodeleeuw Aug 14, 2020 Maintainer

jodeleeuw Aug 14, 2020 Maintainer

GEJ1 Aug 16, 2020 Author

GEJ1 Aug 31, 2020 Author

GEJ1 Aug 31, 2020 Author

GEJ1 Sep 25, 2020 Author

GEJ1 Aug 31, 2020 Author

jodeleeuw Sep 1, 2020 Maintainer

GEJ1 Sep 25, 2020 Author

GEJ1 Sep 29, 2020 Author

jodeleeuw Jan 26, 2021 Maintainer

GEJ1 Jan 26, 2021 Author

Replies: 7 comments 21 replies

GEJ1 Aug 13, 2020
Author

jodeleeuw Aug 14, 2020
Maintainer

jodeleeuw
Aug 14, 2020
Maintainer

GEJ1 Aug 16, 2020
Author

GEJ1 Aug 31, 2020
Author

GEJ1 Aug 31, 2020
Author

GEJ1 Sep 25, 2020
Author

GEJ1 Aug 31, 2020
Author

jodeleeuw
Sep 1, 2020
Maintainer

GEJ1 Sep 25, 2020
Author

GEJ1 Sep 29, 2020
Author

jodeleeuw Jan 26, 2021
Maintainer

GEJ1 Jan 26, 2021
Author