Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Baubles:Ring item. #8

Open
AnrDaemon opened this issue Jul 1, 2024 · 6 comments
Open

Missing Baubles:Ring item. #8

AnrDaemon opened this issue Jul 1, 2024 · 6 comments

Comments

@AnrDaemon
Copy link

The mod is incompatible with Baubles. It is missing the Baubles:Ring item (the Miner's Ring).

@jss2a98aj
Copy link
Owner

The Miner's Ring is an example item, and was not necessary. Unless there was a mod depending on it that I am not aware of, its removal does not break anything.

@AnrDaemon
Copy link
Author

It break existing worlds where the mod is replaced.

@jss2a98aj
Copy link
Owner

It does not. Forge opens a menu (or prompts in the terminal on a server) asking if you want to continue loading the world, and does not do it again unless another items or block is removed.

@AnrDaemon
Copy link
Author

That's not what I mean.

The Miner's Ring is an example item, and was not necessary.

It is not your place to judge the necessity. The item was in the original mod, and to use it or not was entirely up to pack makers.
In my world, for example, the ring is a low chance drop from chests in ExU Underdark, and is a good help for faster resource gathering under threat.

@jss2a98aj
Copy link
Owner

That particular clarification would have been nice in the initial issue description. I'm not opposed to it being re-implemented. If you want it added back in quickly, a pull request would be helpful.

@AnrDaemon
Copy link
Author

You'll have to revert 253625d and at least partially 0c383f7.
Can't do a pull request, sorry, I don't know how much of the latter is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants