Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jstzd): implement pull image #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(jstzd): implement pull image #558

wants to merge 2 commits into from

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Sep 12, 2024 •
edited
Loading

Context

pull image

Description

implement pull image

Manually testing the PR

cargo test --package jstzd --test pull_image

@ryutamago ryutamago mentioned this pull request Sep 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 34.73%. Comparing base (a6aaa2c) to head (d418e66).

Files with missing lines Patch % Lines
crates/jstzd/src/docker/image.rs 0.00% 38 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/docker/image.rs 44.32% <0.00%> (-28.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6aaa2c...d418e66. Read the comment docs.

Base automatically changed from leo/docker-image to main September 17, 2024 11:14
@ryutamago ryutamago force-pushed the leo/docker-pull-image branch from 1982bf9 to 8b9ea4f Compare September 17, 2024 11:56
@ryutamago ryutamago requested a review from johnyob September 17, 2024 11:58
@ryutamago ryutamago force-pushed the leo/docker-pull-image branch 2 times, most recently from c2c89f5 to d418e66 Compare September 17, 2024 12:01
@ryutamago ryutamago requested a review from zcabter September 18, 2024 13:32
@ryutamago ryutamago self-assigned this Sep 18, 2024
@ryutamago ryutamago force-pushed the leo/docker-pull-image branch 5 times, most recently from a330c4e to 934d878 Compare September 23, 2024 15:52
@ryutamago ryutamago force-pushed the leo/docker-pull-image branch from 934d878 to df8eb4d Compare September 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnyob johnyob Awaiting requested review from johnyob

@zcabter zcabter Awaiting requested review from zcabter

At least 1 approving review is required to merge this pull request.

Assignees

@ryutamago ryutamago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryutamago