-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: terminate slow tests #691
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
@@ -135,7 +135,7 @@ in { | |||
# Don't run the `jstz_api` integration tests until they've been paralellized | |||
# | |||
# Note: --workspace is required for --exclude. Once --exclude is removed, remove --workspace | |||
cargoNextestExtraArgs = "--workspace --test \"*\" --exclude \"jstz_api\""; | |||
cargoNextestExtraArgs = "--workspace --test \"*\" --exclude \"jstz_api\" --config-file ${src}/.config/nextest.toml"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this be needed for the cargo-llvm-cov
check as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at cargo llvm-cov test
the option isn't available, but it is for cargo llvm-cov nextest
. #658 changes the command to nextest
-- though this could be split out/included in this PR to avoid PR dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Do you want to split that nextest
change into an individual PR? You can apply config-file
in that PR after this one is merged or I can wait for your PRs and patch cargo-llvm-cov
in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about cargo-llvm-cov
Context
Closes JSTZ-208.
JSTZ-208
Description
Terminate tests that take too much time in CI to save resources and prevent unexpected long-running tests from blocking the CI runner.
Manually testing the PR
A test branch contains changes in this PR and a dummy test that does nothing but sleeps for 2 minutes. Workflow run: https://github.com/jstz-dev/jstz/actions/runs/12035957074/job/33556133877
The test was terminated and the overall check failed as expected.