Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: terminate slow tests #691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: terminate slow tests #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[profile.default]
slow-timeout = { period = "60s", terminate-after = 1 }
4 changes: 2 additions & 2 deletions nix/crates.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
src = let
# Include all Rust files / cargo related files
# Include all files in the `contracts` and `crates` directories
regexes = [".*\.toml$" ".*\.rs$" "^\.cargo.*$" "^Cargo.lock$" "^crates.*$" "^contracts.*$"];
regexes = [".*\.toml$" ".*\.rs$" "^\.cargo.*$" "^Cargo.lock$" "^crates.*$" "^contracts.*$" "\.config.*$"];
in
lib.sourceByRegex (lib.cleanSource ../.) regexes;

Expand Down Expand Up @@ -135,7 +135,7 @@ in {
# Don't run the `jstz_api` integration tests until they've been paralellized
#
# Note: --workspace is required for --exclude. Once --exclude is removed, remove --workspace
cargoNextestExtraArgs = "--workspace --test \"*\" --exclude \"jstz_api\"";
cargoNextestExtraArgs = "--workspace --test \"*\" --exclude \"jstz_api\" --config-file ${src}/.config/nextest.toml";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this be needed for the cargo-llvm-cov check as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at cargo llvm-cov test the option isn't available, but it is for cargo llvm-cov nextest. #658 changes the command to nextest -- though this could be split out/included in this PR to avoid PR dependencies

Copy link
Collaborator Author

@huancheng-trili huancheng-trili Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Do you want to split that nextest change into an individual PR? You can apply config-file in that PR after this one is merged or I can wait for your PRs and patch cargo-llvm-cov in this PR.

});

cargo-llvm-cov = craneLib.cargoLlvmCov (commonWorkspace
Expand Down