Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong transparency value #5

Open
jterrace opened this issue Oct 13, 2013 · 1 comment
Open

Wrong transparency value #5

jterrace opened this issue Oct 13, 2013 · 1 comment

Comments

@jterrace
Copy link
Owner

PNG spec says:

An alpha value of zero represents full transparency, and a value of (2^bitdepth)-1 represents a fully opaque pixel.

So we're using the wrong value for transparency. We should treat 0 as transparent and 255 as opaque.

@jterrace
Copy link
Owner Author

I'm not sure if SSIM actually says anything about what to do with an alpha channel. We can remove entirely transparent values (alpha==0) but the SSIM metric is going to treat partial transparency as if it was fully opaque.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant