numfig bug: :page: references wrong label from one chapter to another

[erikbgithub]

Hi Jeff,

found a bug in numfig.py which can be seen, when :page: reference is one in chapter A but the figure referenced is in chapter B. The current numfig will generate the incorrect latex. Example:

figure \ref{ch-impl/index:fig-desk} on page \pageref{ch-eval/index:fig-desk}

(the \ref block is correct, but the \pageref is wrong, because that label doesn't exist)

I fixed it by copying a lot of code from latex_visit_num_ref to latex_visit_page_ref locally and the page ref method looks like this now:

def latex_visit_page_ref(self, node):
    fields = node['reftarget'].split('#')

    if len(fields) > 1:
        label, target = fields
    else:
        label = None
        target = fields[0]

    if target not in self.builder.env.docnames_by_figname:
        raise nodes.SkipNode
    targetdoc = self.builder.env.docnames_by_figname[target]

    ref_link = '%s:%s' % (targetdoc, target)
    self.body.append("\\pageref{%s}" % ref_link)
    raise nodes.SkipNode

The code is neither optimal nor did I bother to make a commit out of it for now. I mostly want to keep the note here to make this a pull request after I am done with my thesis. Maybe this can be changed already when we replace some of the copy&paste files with a requirements.txt file and get the public numfig project. What do you think? (take your time responding, I know you are busy)