Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document player slot association with an airbase #195

Open
jtoppins opened this issue Apr 27, 2021 · 2 comments
Open

document player slot association with an airbase #195

jtoppins opened this issue Apr 27, 2021 · 2 comments
Labels
doc documentation is needed good first issue Good for newcomers

Comments

@jtoppins
Copy link
Owner

Forgot to document the feature implemented in acdffa9 ("airbase: allow designer to list slots for an airbase").

@jtoppins jtoppins added doc documentation is needed good first issue Good for newcomers labels Apr 27, 2021
@ricmzn
Copy link
Contributor

ricmzn commented Dec 31, 2021

I've made a patch that makes this unnecessary by finding the closest airbase within a (rather permissive) radius: team-limakilo@6c1eae4

What do you think of this approach?

Edit: it doesn't break on the first result because a FARP could be located within an airbase, and the two could be of different coalitions (ie. blue and neutral), or perhaps the airbase could be damaged but the FARP would still be operational, and helicopters would be able to use it.

And in case the closest airbase isn't the one intended by the creator, they would still have to specify it manually.

@jtoppins
Copy link
Owner Author

The concern I have is if a slot gets associated with the wrong airbase then the slot will be locked. So as you point out they would still have to associate the slot manually, which means this still has to get documented. Also the ambiguity of the above FARP status would likely be confusing to most.

Airbases can by subordinate templates of both sides and depending on which faction owns the base those subordinates should be spawned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc documentation is needed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants