Callum-style/chorded layer switching?

[bustinbung]

I've decided to try a callum style keymap, but that means I need to implement some kind of chorded layer system. In essence, holding one key (lmet) activates a navigation layer, holding another (rmet) activates a symbol layer, and holding both together activates a number layer.

There are 4 possible input combinations I've tested so far:

Case 1:
lmet down = navigation
rmet down = symbols

Case 2:
lmet down, rmet down = numbers
rmet down, lmet down = numbers

Case 3:
lmet down, rmet down, rmet up = navigation
rmet down, lmet down, lmet up = symbols

Case 4:
lmet down, rmet down, lmet up = symbols
rmet down, lmet down, rmet up = navigation

Basically, I want each keys' layer to activate instantly and switch to the number layer and back when adding or removing the other.

I was wondering if I can get the behavior I want with the tools we have now. I've included the configs I've tried so far, but I haven't been able to get case 4 to work at all.

;; chord approach
;; works for cases 1 & 2

(deflayer colemak
  @lme @rme
)

(defalias
  sym (layer-while-held symbols)
  nav (layer-while-held navigation)
  num (layer-while-held number)

  lme (multi @nav (chord layers l))
  rme (multi @sym (chord layers r))
)

(defchords layers 5000
  (l  ) @nav
  (  r) @sym
  (l r) @num
)

;; switch approach
;; works for cases 1, 2, & 3

(deflayer colemak
  @lme @rme
)

(defalias
  sym (layer-while-held symbols)
  nav (layer-while-held navigation)
  num (layer-while-held number)

  lme (switch
    ((layer symbols)) @num break
    () @nav fallthrough
  )
  rme (switch
    ((layer navigation)) @num break
    () @sym fallthrough
  )
)

[jtroo]

Here's something that might work: Simulator link

(defsrc a lmet rmet)
(deflayer base
  1 @lme @rme)
(deflayer numbers
  2 @lme @rme)
(deflayer navigation
  3 @lme @rme)
(deflayer symbols
  4 @lme @rme)

(defvirtualkeys
  callum (switch
    ((and nop1 nop2)) (layer-while-held numbers) break
    (nop1) (layer-while-held navigation) break
    (nop2) (layer-while-held symbols) break)
  activate-callum (switch
    ((or nop1 nop2)) 
     (multi (on-press release-vkey callum) (on-press press-vkey callum))
     break
    () (on-press release-vkey callum) break))

(defalias
  lme (multi nop1 
             (on-press tap-vkey activate-callum)
             (on-release tap-vkey activate-callum))
  rme (multi nop2
             (on-press tap-vkey activate-callum)
             (on-release tap-vkey activate-callum)))

[jtroo]

It can probably be made to work by modifying this code to remove the one-shot handling as part of "custom" actions.

kanata/keyberon/src/layout.rs

Lines 1915 to 1925 in fc1b95d

	Custom(value) => {
	self.last_press_tracker.update_coord(coord);
	if !is_oneshot {
	self.oneshot
	.handle_press(OneShotHandlePressKey::Other(coord));
	}
	self.rpt_action = Some(action);
	if self.states.push(State::Custom { value, coord }).is_ok() {
	return CustomEvent::Press(value);
	}
	}

            Custom(value) => {
                self.last_press_tracker.update_coord(coord);
-               if !is_oneshot {
-                   self.oneshot
-                       .handle_press(OneShotHandlePressKey::Other(coord));
-               }
                self.rpt_action = Some(action);
                if self.states.push(State::Custom { value, coord }).is_ok() {
                    return CustomEvent::Press(value);
                }
            }

I don't think this simple workaround should be the general solution though; this could break the use case of a one-shot layer; where the layer remains active instead of getting deactivated, upon doing specific actions that fall under the Custom category.

[bustinbung]

Here's a stripped down version of my config. Link

[jtroo]

I think this PR will be needed to allow persisting one-shot between layer changes #1359

  activate-callum (multi
   (one-shot-pause-processing 5)
   (switch
    ((or nop1 nop2))
     (multi (on-press release-vkey callum)
            (on-press press-vkey callum))
     break
    () (on-press release-vkey callum) break)))

[bustinbung]

Having some issues, but I'll go ahead and create an issue in the issue tracker instead of continuing here because it's with published code.

[bustinbung]

Thanks for doing this, you're amazing <3