Flash install #162
Flash install #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 72.34% 73.04% +0.70%
==========================================
Files 8 8
Lines 282 282
==========================================
+ Hits 204 206 +2
+ Misses 78 76 -2
Continue to review full report at Codecov.
|
| ============================================================================= | ||
|
|
||
| **You must have a USB drive with pytentiostat and pytent_env to use this method.** | ||
| **If you do not have such a drive, you can download the source code at** https://github.com/juami/pytentiostat |
There was a problem hiding this comment.
These instructions are confusing I think. Much better is to give people step by step instructions, and then alternatives if things fail.
For example, I am already stumped on the first one. I have a USB drive (though I don't really need to be told I need this if I am installing from a USB), but I have no idea if I have pytent_env, and no idea how to check or what to do if I don't have it. => frustration and dissatisfaction.
Can it be written more like (without the bold warnings at the top of what can go wrong).
- start and log in to your computer
- place the USB drive into a USB slot in your computer
- <describe what they will see, then what to do, "double click on the folder icon" or sthg like that>
- Drag and drop the folder named
pytentiostatonto your desktop (or into the folder where you want it located) - Look inside the
pytentiostatfolder forpytent_envand inside that folder for a file called
pytent_GUI.bat. - To run the graphical user interface, double click on
pytent_GUI.batto run the software. - If you prefer to run the command-line interface to the software (less common) , double click on
pytent_cmd.bat
|
Hi @jlhitt1993, I don't see the pytent_env folder with a pytent_GUI.bat and a pytent_cmd.bat file in this pull request. Do you have these or are these not yet created? Just trying to figure out where you left off so we don't reinvent the wheel. Thanks! |
|
Hey @pauchery I think there was initally one |
|
@jlhitt1993 ok thank you. We've been working with those .whl and batch files and got PySide2 to install with the batch file. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 72.34% 73.04% +0.70%
==========================================
Files 8 8
Lines 282 282
==========================================
+ Hits 204 206 +2
+ Misses 78 76 -2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I updated the instructions for using the flash drive and removed the batch file for the old method. The new method will contain the batch file inside the env so no need for it here.