Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic code checks? #118

Open
morcuended opened this issue Jun 13, 2024 · 2 comments
Open

Enable automatic code checks? #118

morcuended opened this issue Jun 13, 2024 · 2 comments
Labels
maintenance question Further information is requested

Comments

@morcuended
Copy link
Collaborator

Do we want to enable automatic checks for format, syntax and linting?
It would require to make a lot of modifications and cleanup of the code

@morcuended morcuended added question Further information is requested maintenance labels Jun 13, 2024
@juanep97
Copy link
Owner

I would not enable that, except for perhaps new committed lines.

@morcuended
Copy link
Collaborator Author

I think it could be done for new committed lines. Either activating the precommit hook at the developer level (when you push a commit, it will be formatted, linted, etc). Another way would be to enable the precommit hook in CI but only for diff lines (I think this is also possible).

In any case, although it is not critical, IMO the whole code would benefit from a standard format check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants