Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeWait race condition #4

Open
kmaehashi opened this issue Aug 28, 2015 · 0 comments
Open

changeWait race condition #4

kmaehashi opened this issue Aug 28, 2015 · 0 comments

Comments

@kmaehashi
Copy link
Member

When a container (Jubatus server) become Wait status, it reports its status to ApplicationMaster. In changeWait method of ApplicationMaster, if status of all (currently two) containers become Wait, status of AM become Wait and reports the status to Jubatus-on-Yarn client.

However, as changeWait may be called asynchronously (from two Containers), there is a race condition around L99-L102 that AM status change be notified twice to Jubatus-on-Yarn client. The second status notification will fail, because state cannot be changed from Wait to Wait. As a consequence, 1 of Jubatus server container will occasionally go down.

We should make changeWait synchronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant