Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no error handling when changing state #5

Open
kmaehashi opened this issue Sep 1, 2015 · 0 comments
Open

no error handling when changing state #5

kmaehashi opened this issue Sep 1, 2015 · 0 comments
Assignees
@kmaehashi

Comments

@kmaehashi
Copy link
Member

No error handling when changing the Controller status.

For example, when save method is called,

  • change state from Wait to Saving
  • do save action
  • change state from Saving to Wait

When errors occur in the save action, the state does not go back to Wait state. As a result, save cannot be called anymore for that model.

https://github.com/jubatus/jubatus-on-yarn/blob/v1.0.0/jubatusonyarn/jubatus-on-yarn-container/src/main/scala/us/jubat/yarn/container/ContainerController.scala#L96-L117
@kmaehashi kmaehashi self-assigned this Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmaehashi kmaehashi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmaehashi