Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Mocha@11 #107

Open
vrubezhny opened this issue Dec 2, 2024 · 0 comments · May be fixed by #108
Open

Support for Mocha@11 #107

vrubezhny opened this issue Dec 2, 2024 · 0 comments · May be fixed by #108

Comments

@vrubezhny
Copy link

Please add a support for Mocha@11

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/mocha
npm error   dev mocha@"^11.0.1" from the root project
npm error   peer mocha@">=[5](https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/12125442926/job/33805411456?pr=4680#step:4:6).2.0" from [email protected]
npm error   node_modules/vscode-extension-tester
npm error     dev vscode-extension-tester@"^8.10.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer mocha@"^5.2.0 || ^[6](https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/12125442926/job/33805411456?pr=4680#step:4:7).0 || ^7.0 || ^8.0 || ^9.0 || ^10.0" from [email protected]
npm error node_modules/mocha-jenkins-reporter
npm error   dev mocha-jenkins-reporter@"^0.4.[7](https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/12125442926/job/33805411456?pr=4680#step:4:8)" from the root project
npm error
npm error Conflicting peer dependency: mocha@10.[8](https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/12125442926/job/33805411456?pr=4680#step:4:9).2
npm error node_modules/mocha
npm error   peer mocha@"^5.2.0 || ^6.0 || ^7.0 || ^8.0 || ^[9](https://github.com/redhat-developer/vscode-openshift-tools/actions/runs/12125442926/job/33805411456?pr=4680#step:4:10).0 || ^10.0" from [email protected]
npm error   node_modules/mocha-jenkins-reporter
npm error     dev mocha-jenkins-reporter@"^0.4.7" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
vrubezhny added a commit to vrubezhny/mocha-jenkins-reporter that referenced this issue Dec 2, 2024
@vrubezhny
Add 'Mocha@11' as a peer dependency
ece3465 
Also this updates 'eslint' to v8.57.1 and overrides 'cross-spawn' to ^7.0.6 in order to
fix the known vulnerabilities:

```

ajv  <6.12.3
Severity: moderate
Prototype Pollution in Ajv - GHSA-v88g-cgmw-v5xw
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/ajv
  ajv-keywords  2.1.1
  Depends on vulnerable versions of ajv
  node_modules/ajv-keywords
  eslint  2.5.0 - 2.5.2 || 4.2.0 - 5.0.0-rc.0
  Depends on vulnerable versions of ajv
  Depends on vulnerable versions of cross-spawn
  Depends on vulnerable versions of table
  node_modules/eslint
  table  3.7.10 - 4.0.2
  Depends on vulnerable versions of ajv
  node_modules/table

cross-spawn  <6.0.6
Severity: high
Regular Expression Denial of Service (ReDoS) in cross-spawn - GHSA-3xgq-45jj-v275
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/cross-spawn

5 vulnerabilities (3 moderate, 2 high)
```

Fixes: juhovh#107

Signed-off-by: Victor Rubezhny <[email protected]>
@vrubezhny vrubezhny linked a pull request Dec 2, 2024 that will close this issue
Open
@mojito317 mojito317 mentioned this issue Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'Mocha@11' as a peer dependency vrubezhny/mocha-jenkins-reporter
1 participant
@vrubezhny