Add 'heartbeat_timeout_threshold` option #588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbock
force-pushed
the
heartbeat
branch
3 times, most recently
from
c7ee659
to
43f5cca
Compare
freyes
requested changes
Mar 12, 2021
| @@ -768,6 +768,8 @@ def __call__(self): | |||
| if send_notifications_to_logs: | |||
| ctxt['send_notifications_to_logs'] = send_notifications_to_logs | |||
|
|
|||
| ctxt['rabbit_heartbeat_timeout_threshold'] = conf.get('rabbit_heartbeat_timeout_threshold') | |||
There was a problem hiding this comment.
in the charm's configuration we should use rabbit-heartbeat-timeout-threshold to keep the consistency.
|
LGTM. |
ajkavanagh
suggested changes
Mar 15, 2021
| @@ -768,6 +768,8 @@ def __call__(self): | |||
| if send_notifications_to_logs: | |||
| ctxt['send_notifications_to_logs'] = send_notifications_to_logs | |||
|
|
|||
| ctxt['rabbit_heartbeat_timeout_threshold'] = conf.get('rabbit-heartbeat-timeout-threshold') | |||
There was a problem hiding this comment.
All of the above versions of conf.get() include the default 'None' parameter. For consistency, we should probably include that, please.
This change adds the `heartbeat_timeout_threshold` option to the `oslo_messaging_rabbit` section. It also cleans some uses of `conf.get()` to make use of the default `scope=None` parameter. Closes-Bug: #1918673 Signed-off-by: Nicolas Bock <[email protected]>
|
Looks like unit tests need updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
heartbeat_timeout_thresholdoption to theoslo_messaging_rabbitsection.Closes-Bug: #1918673
Signed-off-by: Nicolas Bock [email protected]