Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run build #194

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix: run build #194

merged 1 commit into from
Apr 16, 2024

Conversation

philipbalbas
Copy link
Contributor

@philipbalbas philipbalbas commented Apr 16, 2024

closes #193


Ellipsis 🚀 This PR description was created by Ellipsis for commit 5d08ad0.

Summary:

This PR enables the build step for the TypeScript SDK in the GitHub Actions workflow by uncommenting the npm run build command in the lint-and-format.yml file.

Key points:

  • Uncommented npm run build command in the lint-and-format.yml workflow file.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 5d08ad0
  • Looked at 14 lines of code in 1 files
  • Took 1 minute and 20 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. .github/workflows/lint-and-format.yml:98:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    Uncommenting the 'npm run build' command will not fix the type errors in the TypeScript code. Please fix these type errors for the build to pass.
  • Reasoning:
    The PR author has uncommented the 'npm run build' command in the GitHub workflow file. This command was previously commented out, which was causing the build to fail. The PR author's change seems to be in line with the intent of fixing the build issue. However, the error logs in the issue description suggest that there are type errors in the TypeScript code. Uncommenting the build command will not fix these type errors. The PR author needs to fix these type errors in the TypeScript code for the build to pass.

Workflow ID: wflow_qt4yxO9D2SkYsAmo


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@creatorrr creatorrr merged commit d9f2a64 into dev Apr 16, 2024
3 of 9 checks passed
@creatorrr creatorrr deleted the f/sdk-js-building branch April 16, 2024 05:18
alt-glitch pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run build is currently failing
2 participants