Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose Electron version #33

Open
christianbundy opened this issue Sep 1, 2020 · 2 comments
Open

Choose Electron version #33

christianbundy opened this issue Sep 1, 2020 · 2 comments

Comments

@christianbundy
Copy link

Hi! Is it possible to choose which version of Electron is used? I'd like to test for support on a few different releases but didn't want to write my own module if it's possible via electron-stream.

@juliangruber
Copy link
Owner

Hey! Electron is currently installed as a dependency through npm, and you can't depend on multiple versions of the same module. It is therefore currently installed at install time, where you can't really pass arguments to it.

What you request would require it instead to be installed at runtime, as it's too expensive to just install all electron versions at once. If there isn't one already, we'd need to write a node module for this, and then integrate it here.

I currently don't have the OSS time to work on this, however if you or someone else is interested, I'm very happy to help.

@christianbundy
Copy link
Author

Thanks for the quick response! I'll see if I can take the code from this repo and just have Electron passed in as an argument after being installed by the user. I'll post updates in this thread if/when I get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants