Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupiter Terminal V3 CSS overrides global page styles #90

Closed
llegoelkelo opened this issue Jun 29, 2024 · 5 comments
Closed

Jupiter Terminal V3 CSS overrides global page styles #90

llegoelkelo opened this issue Jun 29, 2024 · 5 comments

Comments

@llegoelkelo
Copy link

Hey guys, when loading https://terminal.jup.ag/main-v3.js the css file https://terminal.jup.ag/main-3.0.0-Jupiter.css eventually also gets loaded into our dapp but it actually overrides some styles.

So far I have only noticed our buttons being affected but it could be more:

image
@llegoelkelo
Copy link
Author

llegoelkelo commented Jul 2, 2024 •
edited
Loading

You can actually see this in the kitchen sink page as well: https://terminal.jup.ag

llegoelkelo added a commit to llegoelkelo/terminal that referenced this issue Jul 3, 2024
@llegoelkelo
fix: issue that overwrites css when terminal is loaded jup-ag#90
f664ade
@llegoelkelo llegoelkelo mentioned this issue Jul 3, 2024
Closed
@llegoelkelo
Copy link
Author

Turns out this was simply a css injection order. I have submitted a PR.

@llegoelkelo
Copy link
Author

I still have this issue even after #94 was merged and deployed.

@TechTronixx
Copy link

Yep , Just tested & it still persists.

@llegoelkelo
Copy link
Author

maybe I tested too quickly after launch because it definitely works now. Closing. Thanks @worlddlckgh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issue that overwrites css when terminal is loaded llegoelkelo/terminal
2 participants
@TechTronixx @llegoelkelo